Initial certification testing "framework" #1204
Conversation
Co-authored-by: tanvigour <60332928+tanvigour@users.noreply.github.com>
pkedy
changed the title
|
|
||
| daprHTTPPort = runtime.DefaultDaprHTTPPort | ||
| daprAPIGRPCPort = runtime.DefaultDaprAPIGRPCPort | ||
| daprInternalGRPC = runtime.DefaultDaprAPIGRPCPort + 1 |
There was a problem hiding this comment.
Why we do not have a constant value for internal grpc port?
/cc @artursouza @yaron2
There was a problem hiding this comment.
This value is constant. I don't understand the question.
There was a problem hiding this comment.
I think he is asking why there is not a constant for the internal port in dapr/dapr's runtime package. That struck me as strange also. Is the port dynamically selected (which would since)?
| return c.Context.Value(key) | ||
| } | ||
| func (c Context) MustGet(args ...interface{}) { | ||
| if len(args)%2 != 0 { |
There was a problem hiding this comment.
Better to comment magic number here.
There was a problem hiding this comment.
This will be explained in the forthcoming Go docs.
daixiang0
left a comment
daixiang0
left a comment
There was a problem hiding this comment.
LGTM overall, just some nits.
CodeMonkeyLeet
left a comment
CodeMonkeyLeet
left a comment
There was a problem hiding this comment.
LGTM ... are there issues tracking follow-up tasks to this? (e.g. doc on usage, update to dev instructions, integration into github workflow, update devcontainer with terraform etc.)
@halspang @tanvigour @berndverst @dmitsh @mukundansundar, given that this PR is intended to unblock devs on implementing integration tests while the docs are still incoming, you should take a look.
| @@ -0,0 +1,71 @@ | |||
| package terraform | |||
There was a problem hiding this comment.
Are we officially introducing terraform as a dependency into our test environments? Would be good to update the developing-component.md doc, and we should probably add it to the devcontainer definition.
There was a problem hiding this comment.
Not at this time, but the thought was that it could be used to provision various cloud services in the future.
Codecov Report
@@ Coverage Diff @@
## master #1204 +/- ##
=======================================
Coverage 35.07% 35.07%
=======================================
Files 147 147
Lines 12624 12624
=======================================
Hits 4428 4428
Misses 7727 7727
Partials 469 469 Continue to review full report at Codecov.
|
* WIP * tweaks * Simplifying runnables * Increase network timeout * tweaks * More tweaks * Docker compose and structural tweaks Co-authored-by: tanvigour <60332928+tanvigour@users.noreply.github.com> * Tweak * Working Kafka test * Watcher ordered vs unordered * Error simulation * Made port explicit, removed Redis * package.Run (better naming) * terraform related changes * Restructuring certification testing * Remove copied go-sdk client package * Fix terraform.go build issues * Using master of go-sdk * Using main of go-sdk * Tweaks per PR * Adding file headers and some tweaks per PR * More tweaks * More comments in Kafka test Co-authored-by: tanvigour <60332928+tanvigour@users.noreply.github.com> Co-authored-by: Tanvi Gour <tanvi.gour@gmail.com> Co-authored-by: tanvigour <> Co-authored-by: Long Dai <long.dai@intel.com> Co-authored-by: Simon Leet <31784195+CodeMonkeyLeet@users.noreply.github.com>
5 participants
Description
This PR adds the initial certification testing framework. This is intended to be a starting point and evolve over time as requirements evolve.
Note to reviewers: Go docs/comments will be added to this in a future PR. The main motivation for this limited PR now is to get this in the hands of developers that are looking to start using it now knowing that were will be questions. I recommend reaching out on Discord for help.
Checklist